lkml.org 
[lkml]   [2016]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism
    On Wed, Dec 14, 2016 at 10:48:37AM +0900, Milo Kim wrote:
    > Hi Jacek,
    >
    > On 12/13/2016 06:44 PM, Jacek Anaszewski wrote:
    > >
    > > Could you please verify if leds-lp55xx-common.c driver
    > > really needs a custom firmware loading fallback mechanism?
    >
    > Thanks for sharing this. The lp55xx-common uses this mechanism to load and
    > run LED effect manually, so this could be a misuse case.
    > I think the right solution is providing device attributes.

    Run LED manually using request_firmware()? What the.. yes this sounds odd.

    > At this moment, four drivers use lp55xx-common code.
    >
    > - lp5521, lp5523: OK if we do not support FW loading fallback mechanism
    > - lp5562, lp8501: need to create additional sysfs alternatively.

    Phew!

    > However, we should be careful because I'm not sure this modification will
    > generate the regression (breaking the user-space) or not.

    Right so not breaking old userspace is critical.

    Luis

    \
     
     \ /
      Last update: 2016-12-16 10:30    [W:5.732 / U:0.940 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site