lkml.org 
[lkml]   [2016]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] x86/kbuild: enable modversions for symbols exported from asm
    Date
    Michal Marek <mmarek@suse.com> a écrit:

    [...]

    > Does the abidiff tool handle the case when an exported symbol is moved
    > between .c files? This is always a mess with genksyms, because the two
    > .c files have different includes and thus the type expansion stops at
    > different points. So typically the move needs to be reverted as a
    > workaround.

    Let's consider the function:

    'void foo(struct S*);'

    If two ELF binaries contain a definition of that function foo which ELF
    symbol is exported, if the type struct S hasn't changed, and if the only
    difference between the ELF binaries is that foo was defined in the
    translation unit a.c in the first binary and in b.c in the second
    binary, then the comparison engine of libabigail (which is the library
    that abidiff uses) will consider the declarations of the two foo
    functions as being equal -- no matter what include file comes before the
    definition point of foo in a.c and b.c. If it does not, then it's a bug
    that ought to be fixed.

    If you feel that I haven't understood your question, then I guess a
    minimal standalone example (in the form of C source code) that
    illustrates your use case could be helpful to me.

    Thanks.

    --
    Dodji

    \
     
     \ /
      Last update: 2016-12-14 10:01    [W:3.107 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site