lkml.org 
[lkml]   [2016]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] keys/encrypted: Fix two crypto-on-the-stack bugs
    Date
    Andy Lutomirski <luto@amacapital.net> wrote:

    > > - sg_set_buf(&sg_out[1], pad, sizeof pad);
    > > + sg_set_buf(&sg_out[1], empty_zero_page, 16);
    >
    > My fix here is obviously bogus (I meant to use ZERO_PAGE(0)), but what
    > exactly is the code trying to do? The old code makes no sense. It's
    > setting the *output* buffer to zeroed padding.

    Padding goes into the encrypt function and is going to come out of the decrypt
    function. Possibly derived_key_decrypt() should be checking that the padding
    that comes out is actually a bunch of zeros. Maybe we don't actually need to
    get the padding out, but I'm not sure whether the crypto layer will
    malfunction if we don't give it a buffer for the padding.

    David

    \
     
     \ /
      Last update: 2016-12-14 09:39    [W:2.844 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site