Messages in this thread | | | Subject | Re: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler | From | Bart Van Assche <> | Date | Wed, 14 Dec 2016 09:09:45 +0100 |
| |
On 12/08/2016 09:13 PM, Jens Axboe wrote: > +static inline bool dd_rq_is_shadow(struct request *rq) > +{ > + return rq->rq_flags & RQF_ALLOCED; > +}
Hello Jens,
Something minor: because req_flags_t has been defined using __bitwise (typedef __u32 __bitwise req_flags_t) sparse complains for the above function about converting req_flags_t into bool. How about changing the body of that function into "return (rq->rq_flags & RQF_ALLOCED) != 0" to keep sparse happy?
Bart.
| |