Messages in this thread | | | Subject | Re: [PATCH 4.4 01/16] powerpc/eeh: Fix deadlock when PE frozen state cant be cleared | From | Andrew Donnellan <> | Date | Wed, 14 Dec 2016 10:59:32 +1100 |
| |
On 14/12/16 04:15, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > > commit 409bf7f8a02ef88db5a0f2cdcf9489914f4b8508 upstream. > > In eeh_reset_device(), we take the pci_rescan_remove_lock immediately after > after we call eeh_reset_pe() to reset the PCI controller. We then call > eeh_clear_pe_frozen_state(), which can return an error. In this case, we > bail out of eeh_reset_device() without calling pci_unlock_rescan_remove(). > > Add a call to pci_unlock_rescan_remove() in the eeh_clear_pe_frozen_state() > error path so that we don't cause a deadlock later on. > > Reported-by: Pradipta Ghosh <pradghos@in.ibm.com> > Fixes: 78954700631f ("powerpc/eeh: Avoid I/O access during PE reset") > Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > Acked-by: Russell Currey <ruscur@russell.cc> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
It seems that something in your scripts munged the apostrophe in the summary line when generating these emails. Though it looks fine in the actual tree.
Andrew
-- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited
| |