lkml.org 
[lkml]   [2016]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] spi: armada-3700: fix unsigned compare than zero on irq
From
Date
Hello,

Le 13/12/2016 à 11:28, Colin King a écrit :
> From: Colin Ian King <colin.king@canonical.com>
>
> spi->irq is an unsigned integer hence the check if status is less than
> zero has no effect. Fix this by replacing spi->irq with an int irq
> so the less than zero compare will correctly detect errors.
>
> Issue found with static analysis with CoverityScan, CID1388567
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/spi/spi-armada-3700.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
> index e89da0a..4e92178 100644
> --- a/drivers/spi/spi-armada-3700.c
> +++ b/drivers/spi/spi-armada-3700.c
> @@ -800,7 +800,7 @@ static int a3700_spi_probe(struct platform_device *pdev)
> struct spi_master *master;
> struct a3700_spi *spi;
> u32 num_cs = 0;
> - int ret = 0;
> + int irq, ret = 0;
>
> master = spi_alloc_master(dev, sizeof(*spi));
> if (!master) {
> @@ -846,12 +846,13 @@ static int a3700_spi_probe(struct platform_device *pdev)
> goto error;
> }
>
> - spi->irq = platform_get_irq(pdev, 0);
> - if (spi->irq < 0) {
> - dev_err(dev, "could not get irq: %d\n", spi->irq);
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
> + dev_err(dev, "could not get irq: %d\n", irq);
> ret = -ENXIO;
> goto error;
> }
> + spi->irq = irq;
>
> init_completion(&spi->done);
>
>

Why don't you change only the type of "irq" in struct a3700_spi ?

Thanks,
Romain

\
 
 \ /
  Last update: 2016-12-13 11:56    [W:0.047 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site