Messages in this thread | | | Subject | Re: [PATCH] ARM: dts: mvebu: Add Armada 38x labels and clean up Turris Omnia | From | Andreas Färber <> | Date | Mon, 28 Nov 2016 11:52:26 +0100 |
| |
Hi Russell,
Am 28.11.2016 um 11:37 schrieb Russell King - ARM Linux: > On Sun, Nov 27, 2016 at 07:51:39PM +0100, Andreas Färber wrote: >> To more consistently reference nodes by label, add labels for sata, >> usb2, sdhci and usb3 nodes. >> >> Convert all other 38x boards for consistency. Add labels for nfc and rtc. > > Please don't do this for clearfog - there's changes in the pipeline which > completely replace armada-388-clearfog.dts because there's a "base" and > "pro" versions of this hardware now, and making such a huge change will > effectively mean we have to start over with the DT files.
Would it help to split it back up into a series of add-labels, use-labels like I had originally? Then you could start using them in your refactoring as soon as the add-labels patch gets applied. Or are you completely against this style?
Thanks for pointing this out,
Andreas
-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
| |