Messages in this thread | | | Date | Thu, 24 Nov 2016 09:43:31 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c |
| |
On Thu, Nov 24, 2016 at 01:31:03PM +0530, Nayna wrote:
> >>Since the initialization functions are common with the TPM 2.0 event > >>log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > >>event log parsing logic and moves the init functions into > >>tpm_eventlog_init.c. > > > >I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this > >_init thing.. > > Do you mean tpm_eventlog1.c for TPM 1.2 and tpm_eventlog2.c for TPM 2.0 > event log specific parsing ? > > And if so, then which one should have the common functions for TPM 1.2 and > TPM 2.0?
Leave them in tpm_eventlog.c ..
Jason
| |