lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]
Date
Andreas Dilger <adilger@dilger.ca> wrote:

> > + case S_IFCHR: printf(" character special file\n"); ft = 'c'; break;
>
> This will overflow 80 columns. Could use just "character special"?
>
> > + case S_IFDIR: printf(" directory\n"); ft = 'd'; break;
> > + case S_IFBLK: printf(" block special file\n"); ft = 'b'; break;
> > + case S_IFREG: printf(" regular file\n"); ft = '-'; break;
> > + case S_IFLNK: printf(" symbolic link\n"); ft = 'l'; break;
>
> Having these all as single-word items would make it easier to parse for
> test programs. Same with "IO Block:" -> "Blocksize:". Not a huge deal.

Try doing "stat /dev/null".

David

\
 
 \ /
  Last update: 2016-11-24 08:31    [W:0.149 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site