lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 6/6] i2c: use an IRQ to report Host Notify events, not alert
    On Tue, Nov 22, 2016 at 12:49:22PM +0100, Wolfram Sang wrote:
    > On Mon, Nov 21, 2016 at 11:52:48AM +0100, Benjamin Tissoires wrote:
    > > Hi Wolfram,
    > >
    > > On Nov 07 2016 or thereabouts, Wolfram Sang wrote:
    > > > On Thu, Oct 13, 2016 at 02:10:40PM +0200, Benjamin Tissoires wrote:
    > > > > The current SMBus Host Notify implementation relies on .alert() to
    > > > > relay its notifications. However, the use cases where SMBus Host
    > > > > Notify is needed currently is to signal data ready on touchpads.
    > > > >
    > > > > This is closer to an IRQ than a custom API through .alert().
    > > > > Given that the 2 touchpad manufacturers (Synaptics and Elan) that
    > > > > use SMBus Host Notify don't put any data in the SMBus payload, the
    > > > > concept actually matches one to one.
    > > >
    > > > I see the advantages. The only question I have: What if we encounter
    > > > devices in the future which do put data in the payload? Can this
    > > > mechanism be extended to handle that?
    > >
    > > I guess I haven't convinced you with my answer. Is there anything I can
    > > do to get this series in v4.10 or do you prefer waiting for v4.11?
    >
    > I consider this v4.10 material. I was thinking a little about how to not
    > lose data with consecutive interrupts but then -EBUSY came along.
    > Nonetheless, it looks to me like the proper path to follow...

    Applied to for-next, thanks!

    Fixed the following checkpatch warning for you:

    WARNING: struct irq_domain_ops should normally be const
    #250: FILE: drivers/i2c/i2c-core.c:1838:
    +static struct irq_domain_ops i2c_host_notify_irq_ops = {

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-11-24 16:07    [W:2.684 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site