lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path
On 24-11-16, 05:53, Ingo Molnar wrote:
>
> Firstly, please start changes to scheduler code with a verb. This title:
>
> Subject: Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path
>
> is totally inadequate as it's a statement that says nothing about the _change_.
>
> What does the patch do? Does it add, remove, modify, fix or clean up?

Thanks for the tip. I have sometimes seen similar subjects-line in patches from
core developers and so thought it might be right. But yes I understand what you
are saying and will take care of this in future across all subsystems.

> * Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> > Execute the irq-work specific initialization/exit code only when the
> > fast path isn't available.
>
> Is this an optimization? A correctness fix?

Its an optimization but yeah I will try to explain a bit more next time.

--
viresh

\
 
 \ /
  Last update: 2016-11-24 07:13    [W:0.074 / U:1.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site