Messages in this thread | | | Subject | Re: [patch] char/pcmcia: add some error checking in scr24x_read() | From | Lubomir Rintel <> | Date | Thu, 24 Nov 2016 11:48:01 +0100 |
| |
On Thu, 2016-11-24 at 13:46 +0300, Dan Carpenter wrote: > The "ret = " assignment seems to have accidentally been left off. > > Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface > driver") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/char/pcmcia/scr24x_cs.c > b/drivers/char/pcmcia/scr24x_cs.c > index 4f215ce..8523ec5 100644 > --- a/drivers/char/pcmcia/scr24x_cs.c > +++ b/drivers/char/pcmcia/scr24x_cs.c > @@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp, > char __user *buf, size_t count, > ret = -EIO; > goto out; > } > - read_chunk(dev, CCID_HEADER_SIZE, len); > + ret = read_chunk(dev, CCID_HEADER_SIZE, len); > if (ret < 0) > goto out;
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thank you, Lubo
| |