Messages in this thread | | | Date | Thu, 24 Nov 2016 10:06:13 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] pcie: aer: aerdrv: PCIe AER workaround and handling for ASR1K platforms. |
| |
On Wed, 23 Nov 2016, David Singleton wrote: > --- /dev/null > +++ b/arch/x86/platform/asr1k/asr1k_aer.c > @@ -0,0 +1,165 @@ > +/* > + * Cisco ASR1K platform PCIe AER support
Please move this into drivers/platform/x86/asrik/ or into a proper space in drivers/pci/
This is pure driver space and has nothing architecture platform specific in it.
Please sort the proper location out with Bjorn (PCI) and Darren (platform/x86)
> + * > + * Copyright (c) 2015 by cisco Systems, Inc. > + */ > + > +#include <linux/pci.h> > +#include <../../../drivers/pci/pcie/aer/aerdrv.h>
WTF?
If you need to share a header file between files in different directories, what's wrong with moving the file to a proper place in include/* ?
Lack of taste and laziness are the only reasons I can come up with,
Thanks,
tglx
| |