Messages in this thread | | | Date | Mon, 21 Nov 2016 16:23:06 +0200 | From | Heikki Krogerus <> | Subject | Re: [PATCHv11 2/3] usb: USB Type-C connector class |
| |
On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote: > > > +static void typec_partner_release(struct device *dev) > > > +{ > > > + struct typec_port *port = to_typec_port(dev->parent); > > > + > > > + typec_unregister_altmodes(dev); > > > + port->partner = NULL; > > > +} > > > > This doesn't feel right, why are you both exporting > > typec_unregister_altmodes() and also calling it from release callbacks? > > That implies there is two way to clean stuff up, so what is a driver > > writer to use? Please simplify and force it to be one way or the other. > > OK.
Guenter did you need to also remove the alternate modes in drivers, or can we just do it here?
Thanks,
-- heikki
| |