Messages in this thread | | | Subject | Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree | From | John Garry <> | Date | Mon, 21 Nov 2016 14:16:55 +0000 |
| |
On 21/11/2016 13:20, Quentin Lambert wrote: > > > On 11/21/2016 01:53 PM, John Garry wrote: >> However I have noticed that we should do a call to hisi_sas_free() for >> this failure, and later failures in the probe. > I don't understand why, and would welcome the opportunity to learn > something. >
We call hisi_sas_alloc() from hisi_sas_shost_alloc(); if we fail after this in hisi_sas_probe(), then we should free the memmories and workqueue got in hisi_sas_alloc(), which we don't.
Thanks, John
> Quentin > > >
| |