Messages in this thread | | | Date | Wed, 16 Nov 2016 21:33:58 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable access |
| |
Hi Arnd,
On Wed, Nov 16, 2016 at 03:18:18PM +0100, Arnd Bergmann wrote: > gcc warns about a way that it could use an uninitialized variable: > > drivers/pinctrl/sunxi/pinctrl-sunxi.c: In function 'sunxi_pinctrl_init': > drivers/pinctrl/sunxi/pinctrl-sunxi.c:1191:8: error: 'best_div' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This cannot really happen except if 'freq' is UINT_MAX and 'clock' is > zero, and both of these are forbidden. To shut up the warning anyway, > this changes the logic to initialize the return code to the first > divider value before looking at the others. > > Fixes: 7c926492d38a ("pinctrl: sunxi: Add support for interrupt debouncing") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for that patch.
Just out of curiosity, which gcc gives those warnings? I have 6.2 and it didn't output anything..
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |