lkml.org 
[lkml]   [2016]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: nand: nandsim: fix error check
On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote:
>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or
>> a pointer on success. They do not return the error value with ERR_PTR.
>> So we should not check the return with IS_ERR_OR_NULL, instead we
>> should just check for NULL.
>>
>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>> ---
>> drivers/mtd/nand/nandsim.c | 9 +++------
>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
>> index c76287a..9b0d79a 100644
>> --- a/drivers/mtd/nand/nandsim.c
>> +++ b/drivers/mtd/nand/nandsim.c
>> @@ -525,15 +525,13 @@ static int nandsim_debugfs_create(struct nandsim *dev)
>> {
>> struct nandsim_debug_info *dbg = &dev->dbg;
>> struct dentry *dent;
>> - int err;
>> + int err = -ENODEV;
>
> Why don't you just nuke the err altogether and just return -ENODEV ?

That was the first version which i made and discarded before sending. I
will go and find it now.

Regards
Sudip

\
 
 \ /
  Last update: 2016-11-16 08:53    [W:0.044 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site