lkml.org 
[lkml]   [2016]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [GIT PULL] fbdev fixes for 4.9
Date
Tomi Valkeinen <tomi.valkeinen@ti.com> writes:

> [ Unknown signature status ]
> On 14/11/16 18:25, Linus Torvalds wrote:
>> On Mon, Nov 14, 2016 at 3:44 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>>>
>>> Please pull two fbdev fixes for 4.9.
>>
>> No.
>>
>> This has obviously never even been test-compiled. It introduces two
>> new annoying warnings.
>
> Sorry about that. I dropped the patch for now and here's a new pull request.
>
> I did test compile, and I would have noticed errors but I missed the warnings
> (I blame the flu...). I need to improve my testing methods, but I couldn't find
> a way to add -Werror to kernel builds.

You can turn it on per-directory, eg:

diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index ee8c81405a7f..2ee96810d26d 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -4,6 +4,8 @@

# Each configuration option enables a list of files.

+subdir-ccflags-y := -Werror
+
obj-y += core/

obj-$(CONFIG_FB_MACMODES) += macmodes.o

cheers

\
 
 \ /
  Last update: 2016-11-16 07:16    [W:0.407 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site