lkml.org 
[lkml]   [2016]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 01/34] [media] DaVinci-VPBE: Use kmalloc_array() in vpbe_initialize()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 11 Oct 2016 09:40:41 +0200

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kmalloc_array".

    This issue was detected by using the Coccinelle software.

    * Replace the specification of a data type by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/platform/davinci/vpbe.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
    index 9a6c2cc..8c062ff 100644
    --- a/drivers/media/platform/davinci/vpbe.c
    +++ b/drivers/media/platform/davinci/vpbe.c
    @@ -676,9 +676,9 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
    * store venc sd index.
    */
    num_encoders = vpbe_dev->cfg->num_ext_encoders + 1;
    - vpbe_dev->encoders = kmalloc(
    - sizeof(struct v4l2_subdev *)*num_encoders,
    - GFP_KERNEL);
    + vpbe_dev->encoders = kmalloc_array(num_encoders,
    + sizeof(*vpbe_dev->encoders),
    + GFP_KERNEL);
    if (NULL == vpbe_dev->encoders) {
    v4l2_err(&vpbe_dev->v4l2_dev,
    "unable to allocate memory for encoders sub devices");
    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-12 16:30    [W:4.090 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site