lkml.org 
[lkml]   [2016]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3.4 027/125] firewire: ohci: fix JMicron JMB38x IT context discovery
    On Oct 12 lizf@kernel.org wrote:
    [...]
    > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    > [lizf: Backported to 3.4: use dev_notice() instead of ohci_notice()]
    > Signed-off-by: Zefan Li <lizefan@huawei.com>
    > ---
    > drivers/firewire/ohci.c | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
    > index c1de4c3..4eedb07 100644
    > --- a/drivers/firewire/ohci.c
    > +++ b/drivers/firewire/ohci.c
    > @@ -3620,6 +3620,11 @@ static int __devinit pci_probe(struct pci_dev *dev,
    >
    > reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, ~0);
    > ohci->it_context_support = reg_read(ohci, OHCI1394_IsoXmitIntMaskSet);
    > + /* JMicron JMB38x often shows 0 at first read, just ignore it */
    > + if (!ohci->it_context_support) {
    > + dev_notice(&dev->dev, "overriding IsoXmitIntMask\n");
    > + ohci->it_context_support = 0xf;
    > + }
    > reg_write(ohci, OHCI1394_IsoXmitIntMaskClear, ~0);
    > ohci->it_context_mask = ohci->it_context_support;
    > ohci->n_it = hweight32(ohci->it_context_mask);

    Backport looks good to me. Thanks.
    --
    Stefan Richter
    -======----- =-=- -==--
    http://arcgraph.de/sr/

    \
     
     \ /
      Last update: 2016-10-12 15:09    [W:4.222 / U:0.496 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site