lkml.org 
[lkml]   [2016]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 32/68] perf c2c report: Add 'pid' sort key
    Date
    From: Jiri Olsa <jolsa@kernel.org>

    It is to be displayed in the single cacheline output:

    pid

    We currently don't have a single 'pid' sort/display entry, which would
    output just pid number, hence adding it into c2c code.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Don Zickus <dzickus@redhat.com>
    Cc: Joe Mario <jmario@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/n/tip-3o23qrspxc99b04ci1swlzr6@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-c2c.c | 25 +++++++++++++++++++++++++
    1 file changed, 25 insertions(+)

    diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
    index c718d8b553ce..4795713ad211 100644
    --- a/tools/perf/builtin-c2c.c
    +++ b/tools/perf/builtin-c2c.c
    @@ -810,6 +810,22 @@ percent_stores_l1miss_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
    STAT_FN(lcl_dram)
    STAT_FN(rmt_dram)

    +static int
    +pid_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
    + struct hist_entry *he)
    +{
    + int width = c2c_width(fmt, hpp, he->hists);
    +
    + return scnprintf(hpp->buf, hpp->size, "%*d", width, he->thread->pid_);
    +}
    +
    +static int64_t
    +pid_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
    + struct hist_entry *left, struct hist_entry *right)
    +{
    + return left->thread->pid_ - right->thread->pid_;
    +}
    +
    #define HEADER_LOW(__h) \
    { \
    .line[1] = { \
    @@ -1074,6 +1090,14 @@ static struct c2c_dimension dim_dram_rmt = {
    .width = 8,
    };

    +static struct c2c_dimension dim_pid = {
    + .header = HEADER_LOW("Pid"),
    + .name = "pid",
    + .cmp = pid_cmp,
    + .entry = pid_entry,
    + .width = 7,
    +};
    +
    static struct c2c_dimension *dimensions[] = {
    &dim_dcacheline,
    &dim_offset,
    @@ -1103,6 +1127,7 @@ static struct c2c_dimension *dimensions[] = {
    &dim_percent_stores_l1miss,
    &dim_dram_lcl,
    &dim_dram_rmt,
    + &dim_pid,
    NULL,
    };

    --
    2.7.4
    \
     
     \ /
      Last update: 2016-10-11 20:02    [W:4.514 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site