lkml.org 
[lkml]   [2016]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH 02/11] drm/fb-helper: Skip writeback connectors
    On Tue, Oct 11, 2016 at 6:47 PM, Brian Starkey <brian.starkey@arm.com> wrote:
    > On Tue, Oct 11, 2016 at 05:44:48PM +0200, Daniel Vetter wrote:
    >>
    >> On Tue, Oct 11, 2016 at 03:53:59PM +0100, Brian Starkey wrote:
    >>>
    >>> Writeback connectors aren't much use to the fbdev helpers, as they won't
    >>> show anything to the user. Skip them when looking for candidate output
    >>> configurations.
    >>>
    >>> Signed-off-by: Brian Starkey <brian.starkey@arm.com>
    >>> ---
    >>> drivers/gpu/drm/drm_fb_helper.c | 4 ++++
    >>> 1 file changed, 4 insertions(+)
    >>>
    >>> diff --git a/drivers/gpu/drm/drm_fb_helper.c
    >>> b/drivers/gpu/drm/drm_fb_helper.c
    >>> index 03414bd..dedf6e7 100644
    >>> --- a/drivers/gpu/drm/drm_fb_helper.c
    >>> +++ b/drivers/gpu/drm/drm_fb_helper.c
    >>> @@ -2016,6 +2016,10 @@ static int drm_pick_crtcs(struct drm_fb_helper
    >>> *fb_helper,
    >>> if (modes[n] == NULL)
    >>> return best_score;
    >>>
    >>> + /* Writeback connectors aren't much use for fbdev */
    >>> + if (connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)
    >>> + return best_score;
    >>
    >>
    >> I think we could handle this by always marking writeback connectors as
    >> disconnected. Userspace and fbdev emulation should then avoid them,
    >> always.
    >> -Daniel
    >>
    >
    > Good idea; I'll need to take a closer look at how it would interact
    > with the probe helper (connector->force etc).
    >
    > Are you thinking instead-of or in-addition-to the client cap? I'd be
    > worried about apps doing strange things and trying to use even
    > disconnected connectors.

    Apps shouldn't try to use disconnected connectors, at least by
    default. I think we wouldn't need the cap in that case.
    -Daniel
    --
    Daniel Vetter
    Software Engineer, Intel Corporation
    +41 (0) 79 365 57 48 - http://blog.ffwll.ch

    \
     
     \ /
      Last update: 2016-10-11 18:57    [W:4.462 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site