Messages in this thread | | | From | Joel Fernandes <> | Date | Tue, 11 Oct 2016 07:46:38 -0700 | Subject | Re: [PATCH 3/7] pstore: Remove case of PSTORE_TYPE_PMSG write using deprecated function |
| |
On Mon, Oct 10, 2016 at 4:52 PM, Kees Cook <keescook@chromium.org> wrote: > On Fri, Oct 7, 2016 at 10:28 PM, Joel Fernandes <joelaf@google.com> wrote: >> PMSG now uses ramoops_pstore_write_buf_user instead of ramoops_pstore_write_buf >> Remove the case where we check PSTORE_TYPE_PMSG case. > > Ah yeah, good point. Can you actually improve this to add a > ratelimited WARN() to both _write_buf and write_buf_user when an > unhandled type is encountered?
Sure, I'll add that. I'll also use the kcalloc as you suggest in the other thread and add module parameter, DT entry.
Thanks, Joel
| |