Messages in this thread | | | From | Wanpeng Li <> | Date | Tue, 11 Oct 2016 12:05:42 +0800 | Subject | Re: [PATCH 2/2] x86, kvm: use kvmclock to compute TSC deadline value |
| |
2016-09-10 0:38 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>: > > > On 09/09/2016 00:13, David Matlack wrote: >> Hi Paolo, >> >> On Tue, Sep 6, 2016 at 3:29 PM, Paolo Bonzini <pbonzini@redhat.com> wrote: >>> Bad things happen if a guest using the TSC deadline timer is migrated. >>> The guest doesn't re-calibrate the TSC after migration, and the >>> TSC frequency can and will change unless your processor supports TSC >>> scaling (on Intel this is only Skylake) or your data center is perfectly >>> homogeneous. >> >> Sorry, I forgot to follow up on our discussion in v1. One thing we >> discussed there was using the APIC Timer to workaround a changing TSC >> rate. You pointed out KVM's TSC deadline timer got a nice performance >> boost recently, which makes it preferable. Does it makes sense to >> apply the same optimization (using the VMX preemption timer) to the >> APIC Timer, instead of creating a new dependency on kvmclock? > > Hi, yes it does.
Windows 2008 server, 2012 server etc are still using APIC Timer periodic mode, so I am adding the VMX preemption timer support to APIC Timer one shot/periodic mode currently.
Regards, Wanpeng Li
| |