lkml.org 
[lkml]   [2016]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] X.509: Partially revert patch to add validation against IMA MOK keyring
    From
    Date
    On Thu, 2016-01-07 at 00:34 +0000, David Howells wrote:
    > David Howells <dhowells@redhat.com> wrote:
    >
    > > Partially revert commit 41c89b64d7184a780f12f2cccdabe65cb2408893:
    > >
    > > Author: Petko Manolov <petkan@mip-labs.com>
    > > Date: Wed Dec 2 17:47:55 2015 +0200
    > > IMA: create machine owner and blacklist keyrings
    > >
    > > The problem is that prep->trusted is a simple boolean and the additional
    > > x509_validate_trust() call doesn't therefore distinguish levels of
    > > trustedness, but is just OR'd with the result of validation against the
    > > system trusted keyring.
    > >
    > > However, setting the trusted flag means that this key may be added to *any*
    > > trusted-only keyring - including the system trusted keyring.

    Hm, I'm not able to add a key to the system keyring that is signed by a
    key on either the system or the IMA MOK keyrings. The system keyring
    seems to be "locked". A key that is signed by either a key on the
    system or the IMA MOK keyring can be added to the IMA keyring.

    keyctl show %keyring:.system_keyring
    Keyring
    973688077 ---lswrv 0 0 keyring: .system_keyring

    evmctl import m1-cert-signed.der 973688077
    add_key failed
    errno: Permission denied (13)

    Mimi

    > > Whilst I appreciate what the patch is trying to do, I don't think this is
    > > quite the right solution.

    > Please apply this to security/next.
    >
    > Thanks,
    > David




    \
     
     \ /
      Last update: 2016-01-07 03:21    [W:3.217 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site