Messages in this thread | | | Subject | Re: [PATCH 00/19] irqchip: atmel-aic: make unified AIC driver | From | Milo Kim <> | Date | Wed, 6 Jan 2016 16:55:00 +0900 |
| |
Hi Nicolas,
On 01/04/2016 06:37 PM, Nicolas Ferre wrote: > Le 04/01/2016 10:02, Boris Brezillon a écrit : >> Hi Milo, >> >> On Mon, 4 Jan 2016 13:28:24 +0900 >> Milo Kim <milo.kim@ti.com> wrote: >> >>> This patch-set provides unified Atmel AIC (Advanced Interrupt Controller) >>> driver. Currently, there are two AIC drivers, AIC and AIC5. >>> Each driver consists of chip specific part (irq-atmel-aic.o or >>> irq-atmel-aic5.o) and shared code (irq-atmel-aic-common.o). >>> But consolidated AIC driver is just one file driver which supports both >>> IRQ chip systems. >> >> Sorry, but what's the real motivation behind this rework? > > I was about to ask the same question. > > I'm really sorry that you spent so much time and effort for something > that I'm absolutely against: reworking stable code that had been > maturing for years and that is now nicely stable... for no obvious reason...
That's fine. It's not a problem. I enjoyed the time :) I was also concerning about a regression. Let me try to rework common part then.
> > So unless there is a very strong benefit, it's a pretty firm NACK for > this series. We will certainly take some time to review the bits that > can be taken further to enhance our current drivers.
Sure, I totally agree.
> > I also advice you to talk to us before starting such a big project and > you'll notice that we are open to changes and have many aspect that you > can work on with AT91.
I'll keep in mind. Thanks for your advice.
Best regards, Milo
| |