Messages in this thread | | | From | Laurent Pinchart <> | Subject | Re: [PATCH 07/10] [media] tvp5150: Add device tree binding document | Date | Wed, 06 Jan 2016 13:00:31 +0200 |
| |
On Wednesday 06 January 2016 07:46:35 Javier Martinez Canillas wrote: > On 01/06/2016 07:39 AM, Laurent Pinchart wrote: > > Hi Javier, > > > > Thank you for the patch. > > Thanks a lot for your feedback. > > [snip] > > >> + > >> +Optional Properties: > >> +- powerdown-gpios: phandle for the GPIO connected to the PDN pin, if > >> any. > > > > The signal is called PDN in the datasheet, so it might make sense to call > > this pdn-gpios. I have no strong opinion on this, I'll let you decide > > what you think is best. > > Yes, I wondered if the convention was to use a descriptive name or the one > used in the datasheet but Documentation/devicetree/bindings/gpio/gpio.txt > says nothing about it.
The device tree maintainers might want to comment on that :-)
> I'll change it to pdn-gpios since it could be easier to match with the doc.
-- Regards,
Laurent Pinchart
| |