lkml.org 
[lkml]   [2016]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 123/126] sched/core: Remove false-positive warning from wake_up_process()
    Date
    3.16.7-ckt22 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sasha Levin <sasha.levin@oracle.com>

    commit 119d6f6a3be8b424b200dcee56e74484d5445f7e upstream.

    Because wakeups can (fundamentally) be late, a task might not be in
    the expected state. Therefore testing against a task's state is racy,
    and can yield false positives.

    Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: oleg@redhat.com
    Fixes: 9067ac85d533 ("wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACED task")
    Link: http://lkml.kernel.org/r/1448933660-23082-1-git-send-email-sasha.levin@oracle.com
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    kernel/sched/core.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/kernel/sched/core.c b/kernel/sched/core.c
    index 0417f4b1a5f3..c49c16c405b7 100644
    --- a/kernel/sched/core.c
    +++ b/kernel/sched/core.c
    @@ -1772,7 +1772,6 @@ out:
    */
    int wake_up_process(struct task_struct *p)
    {
    - WARN_ON(task_is_stopped_or_traced(p));
    return try_to_wake_up(p, TASK_NORMAL, 0);
    }
    EXPORT_SYMBOL(wake_up_process);

    \
     
     \ /
      Last update: 2016-01-06 12:21    [W:4.142 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site