lkml.org 
[lkml]   [2016]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power
    On Wed, Jan 06, 2016 at 04:53:44PM +0800, Leo Yan wrote:
    > k_po/k_pu are two proportional term constants and essentially they have
    > fixed ratio compared with sustainable power. In current implementation,
    > k_po and k_pu are absolute value after calculation and cannot represent
    > the ratio relationship with sustainable power; as a result, when change
    > sustainable power we cannot smoothly change proportional term constant.

    In v2 Daniel said that the use case was made up. Can you elaborate on
    why we need this?

    > So this patch series introduces k_po_ratio and k_pu_ratio, which
    > represent the ratio value compared against sustainable power. Also add
    > sys file system nodes for them for easily update them from userspace and
    > update a bit in documentation.

    Actually, it makes it harder to update from userspace. Now userspace
    can't set a k_po/k_pu any more, and it's forced to set them as ratios
    of sustainable power. I'd rather not do this unless there is a good
    reason for it.

    Cheers,
    Javi


    \
     
     \ /
      Last update: 2016-01-06 11:21    [W:3.605 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site