lkml.org 
[lkml]   [2016]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional
On Mon, Nov 30, 2015 at 01:55:19PM +0100, Linus Walleij wrote:
> On Fri, Nov 20, 2015 at 10:45 PM, Li Yang <leoli@freescale.com> wrote:
>
> > - if (IS_ERR(i2c_imx->pinctrl)) {
> > + /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
> > + if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
> > + PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {
>
> This is one of the evils of deferred probe: you never know if
> something will eventually turn up. It feels wrong to bail out
> on deferred probe...
>
> I have no better idea though.
> Acked-by

Linus, proper ack next time please, so patchwork will pick it up
automatically.

Li Yang: There have been some other changes to the imx driver. Could you
rebase against my for-next or for-4.5 and add Linus' ack? Thanks!

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-01-03 20:01    [W:0.032 / U:2.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site