Messages in this thread | | | Date | Sun, 3 Jan 2016 14:10:51 +0000 | From | One Thousand Gnomes <> | Subject | Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp |
| |
On Sat, 02 Jan 2016 23:54:28 -0800 Joe Perches <joe@perches.com> wrote:
> On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file. One fork of the core driver uses > > tabs for this indentation while the other uses spaces. Better to use > > flush-left alignment throughout. > > > > This patch is the result of the following substitution. It replaces tabs > > and spaces at the start of a comment line with a single space. > > > > perl -i -pe 's,^(\t*[/ ]\*)[ \t]+,$1 ,' drivers/scsi/{atari_,}NCR5380.c > > > > This removes some unimportant discrepancies between the two core driver > > forks so that the important ones become obvious, to facilitate > > reunification. > > I still think this patch is poor at best and > overall not useful.
I would beg to differ. As a tool for understanding the differences as you step through the versions it's invaluable.
Alan
| |