lkml.org 
[lkml]   [2016]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/26] perf annotate: Rename 'colors.code' to 'colors.jump_arrows'
    Date
    From: Taeung Song <treeze.taeung@gmail.com>

    USe 'jump_arrows' config name instead of 'code' on 'colors' section.
    'colors.code' config is only for jump arrows on assembly code listings
    i.e.

    │ ┌──jmp 1333
    │ │ xchg %ax,%ax
    │ │ mov %r15,%r10
    │ └─→cmp %r15,%r14

    But this config name seems unfit.

    'jump_arrows' is more descriptive than 'code'.

    Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: http://lkml.kernel.org/r/1452240971-25418-1-git-send-email-treeze.taeung@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/Documentation/perf-config.txt | 2 +-
    tools/perf/Documentation/perfconfig.example | 2 +-
    tools/perf/ui/browser.c | 4 ++--
    tools/perf/ui/browser.h | 2 +-
    tools/perf/ui/browsers/annotate.c | 2 +-
    5 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt
    index b9ca1e304158..1ee488b9aaf7 100644
    --- a/tools/perf/Documentation/perf-config.txt
    +++ b/tools/perf/Documentation/perf-config.txt
    @@ -62,7 +62,7 @@ Given a $HOME/.perfconfig like this:
    medium = green, default
    normal = lightgray, default
    selected = white, lightgray
    - code = blue, default
    + jump_arrows = blue, default
    addr = magenta, default
    root = white, blue

    diff --git a/tools/perf/Documentation/perfconfig.example b/tools/perf/Documentation/perfconfig.example
    index 767ea2436e1c..1d8d5bc4cd2d 100644
    --- a/tools/perf/Documentation/perfconfig.example
    +++ b/tools/perf/Documentation/perfconfig.example
    @@ -5,7 +5,7 @@
    medium = green, lightgray
    normal = black, lightgray
    selected = lightgray, magenta
    - code = blue, lightgray
    + jump_arrows = blue, lightgray
    addr = magenta, lightgray

    [tui]
    diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
    index d37202121689..af68a9d488bf 100644
    --- a/tools/perf/ui/browser.c
    +++ b/tools/perf/ui/browser.c
    @@ -531,8 +531,8 @@ static struct ui_browser_colorset {
    .bg = "yellow",
    },
    {
    - .colorset = HE_COLORSET_CODE,
    - .name = "code",
    + .colorset = HE_COLORSET_JUMP_ARROWS,
    + .name = "jump_arrows",
    .fg = "blue",
    .bg = "default",
    },
    diff --git a/tools/perf/ui/browser.h b/tools/perf/ui/browser.h
    index 01781de59532..be3b70eb5fca 100644
    --- a/tools/perf/ui/browser.h
    +++ b/tools/perf/ui/browser.h
    @@ -7,7 +7,7 @@
    #define HE_COLORSET_MEDIUM 51
    #define HE_COLORSET_NORMAL 52
    #define HE_COLORSET_SELECTED 53
    -#define HE_COLORSET_CODE 54
    +#define HE_COLORSET_JUMP_ARROWS 54
    #define HE_COLORSET_ADDR 55
    #define HE_COLORSET_ROOT 56

    diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
    index 718bd46d47fa..4fc208e82c6f 100644
    --- a/tools/perf/ui/browsers/annotate.c
    +++ b/tools/perf/ui/browsers/annotate.c
    @@ -284,7 +284,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser)
    to = (u64)btarget->idx;
    }

    - ui_browser__set_color(browser, HE_COLORSET_CODE);
    + ui_browser__set_color(browser, HE_COLORSET_JUMP_ARROWS);
    __ui_browser__line_arrow(browser, pcnt_width + 2 + ab->addr_width,
    from, to);
    }
    --
    2.5.0
    \
     
     \ /
      Last update: 2016-01-26 21:01    [W:7.923 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site