lkml.org 
[lkml]   [2016]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values
    From
    Date
    On 27.01.2016 04:20, Javier Martinez Canillas wrote:
    > The driver has some hard-coded values such as the minimum delay needed
    > before a RTC update or the mask used for the sec/min/hour/etc registers.
    >
    > Use a data structure that contains these values and pass as driver data
    > using the platform device ID table for each device.
    >
    > This allows to make the driver's ops callbacks more generic so other RTC
    > that are similar but don't have the same values can also be supported.
    >
    > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
    > Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
    >
    > ---
    >
    > Changes in v3:
    > - Fix max77686 delay. Suggested by Krzysztof Kozlowski.
    > - Assign mask to u8 instead of int. Suggested by Krzysztof Kozlowski.
    > - Add Laxman Dewangan's Acked-by tag to patch #4.
    >
    > Changes in v2:
    > - Add a max77686 prefix to rtc_driver_data. Suggested by Krzysztof Kozlowski.
    > - Comment about the .delay and .mask fields. Suggested by Krzysztof Kozlowski.
    > - Change .mask type to u8. Suggested by Krzysztof Kozlowski.
    > - Make .drv_data field const. Suggested by Krzysztof Kozlowski.
    > - Don't cast to drop const on .drv_data asign. Suggested by Krzysztof Kozlowski.
    > - Use platform_get_device_id() macro. Suggested by Krzysztof Kozlowski.
    >
    > drivers/rtc/rtc-max77686.c | 51 ++++++++++++++++++++++++++++++----------------
    > 1 file changed, 34 insertions(+), 17 deletions(-)
    >

    Tested on Trats2 (max77686):
    Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2016-01-27 03:21    [W:8.354 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site