lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RESEND PATCH 3/3] vfs: show_vfsstat: remove redundant initialization and check of error code
    Date: Wed Nov 18 21:09:45 2015 +0000

    As err variable is now always checked right after each assignment, its
    initialization is redundant and could be safely removed. For the same
    reason, the last check of err is also redundant and could be removed as
    well.

    Suggested-by: Mateusz Guzik <mguzik@redhat.com>
    Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
    ---
    fs/proc_namespace.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c
    index 7a6b2f3..3f1190d 100644
    --- a/fs/proc_namespace.c
    +++ b/fs/proc_namespace.c
    @@ -193,7 +193,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
    struct mount *r = real_mount(mnt);
    struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };
    struct super_block *sb = mnt_path.dentry->d_sb;
    - int err = 0;
    + int err;

    /* device */
    if (sb->s_op->show_devname) {
    @@ -224,8 +224,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
    /* optional statistics */
    if (sb->s_op->show_stats) {
    seq_putc(m, ' ');
    - if (!err)
    - err = sb->s_op->show_stats(m, mnt_path.dentry);
    + err = sb->s_op->show_stats(m, mnt_path.dentry);
    }

    seq_putc(m, '\n');
    --
    ldv

    \
     
     \ /
      Last update: 2016-01-11 17:21    [W:6.066 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site