lkml.org 
[lkml]   [2016]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()
    From
    Date
    Hello

    On 1/2/2016 12:33 AM, SF Markus Elfring wrote:

    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Fri, 1 Jan 2016 22:27:20 +0100
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Move the jump label directly before the desired log statement
    > so that the variable "err" will not be checked once more
    > after it was determined that a function call failed.
    > Use the identifier "report_failure" instead of the label "err".

    Why? The code was smart enough and you're making it uglier that it needs
    to be.

    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    MBR, Sergei



    \
     
     \ /
      Last update: 2016-01-02 01:01    [W:4.023 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site