Messages in this thread | | | Subject | Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker() | From | Sergei Shtylyov <> | Date | Sat, 2 Jan 2016 02:14:46 +0300 |
| |
Hello
On 1/2/2016 12:33 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 1 Jan 2016 22:27:20 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable "err" will not be checked once more > after it was determined that a function call failed. > Use the identifier "report_failure" instead of the label "err".
Why? The code was smart enough and you're making it uglier that it needs to be.
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
MBR, Sergei
| |