Messages in this thread | | | Date | Wed, 09 Sep 2015 17:08:06 -0700 (PDT) | Subject | Re: [PATCH v4] stmmac: fix check for phydev being open | From | David Miller <> |
| |
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com> Date: Wed, 9 Sep 2015 18:01:08 +0300
> Current check of phydev with IS_ERR(phydev) may make not much sense > because of_phy_connect() returns NULL on failure instead of error value. > > Still for checking result of phy_connect() IS_ERR() makes perfect sense. > > So let's use combined check IS_ERR_OR_NULL() that covers both cases. > > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> > Cc: linux-kernel@vger.kernel.org > Cc: stable@vger.kernel.org > Cc: David Miller <davem@davemloft.net> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Applied, thanks.
| |