Messages in this thread | | | Subject | Re: [PATCH 3/3] staging: fbtft: use pr_fmt | From | Noralf Trønnes <> | Date | Wed, 9 Sep 2015 23:20:08 +0200 |
| |
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: > On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: >> Instead of defining DRVNAME and using it in all calls to pr_* family of >> macros lets start using pr_fmt. >> >> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> >> --- >> drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++-------------------- >> 1 file changed, 35 insertions(+), 44 deletions(-)
[...]
> If a driver is working properly, nothing should show up in the kernel > log at all, otherwise it's just noise that everyone ignores.
This isn't a device driver, it's a module for adding "fbtft" devices (spi/platform with pdata). When I created fbtft, the Raspberry Pi didn't have Device Tree support, so I made this module as a way for the end user to add devices without having to build a kernel. I haven't seen any module like this in the kernel, so maybe it really doesn't belong here at all?
Noralf.
| |