Messages in this thread | | | Date | Wed, 9 Sep 2015 16:36:57 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH V9 6/6] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report by --freq-perf |
| |
On Tue, Sep 08, 2015 at 03:32:49PM -0400, kan.liang@intel.com wrote: > From: Kan Liang <kan.liang@intel.com> > > Show frequency, CPU Utilization and percent performance for each symbol > in perf report by --freq-perf > > In sampling group, only group leader do sampling. So only need to print > group leader's freq in --group. > > --freq-perf option also implies --group. > > Here is an example. > > $ perf report --stdio --freq-perf > > Overhead FREQ MHz CPU% CORE_BUSY% > Command Shared Object Symbol > ........................................ ......... ..... .......... > ........... ................ ...................... > > 99.54% 99.54% 99.53% 99.53% 99.53% 2301 96 99 > tchain_edit tchain_edit [.] f3 > 0.20% 0.20% 0.20% 0.20% 0.20% 2301 98 99 > tchain_edit tchain_edit [.] f2 > 0.05% 0.05% 0.05% 0.05% 0.05% 2300 98 99 > tchain_edit [kernel.vmlinux] [k] read_tsc > > Signed-off-by: Kan Liang <kan.liang@intel.com>
it seems ok to me, though I think it could be split into HPP__SINGLE_PRINT_FNS support and the rest..
but I prefer if Arnaldo or Namhyung could review this one
thanks, jirka
| |