| Date | Wed, 9 Sep 2015 14:30:27 +0100 | From | David Vrabel <> | Subject | Re: [PATCH v12 07/21] x86/xen: Add stack frame dependency to hypercall inline asm calls |
| |
On 09/09/15 14:21, Josh Poimboeuf wrote: > If a hypercall is inlined at the beginning of a function, gcc can insert > the call instruction before setting up a stack frame, which breaks frame > pointer convention if CONFIG_FRAME_POINTER is enabled and can result in > a bad stack trace. > > Force a stack frame to be created if CONFIG_FRAME_POINTER is enabled by > listing the stack pointer as an output operand for the hypercall inline > asm statements.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
|