lkml.org 
[lkml]   [2015]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel
From
Date
Dne 8.9.2015 v 22:24 Petr Cvek napsal(a):
>
> Did you defined resources somewhere? Actual resources are in "pxa_ir_resources" variable at:
>
> http://lxr.free-electrons.com/source/arch/arm/mach-pxa/devices.c#L386
>
> or this pdata should be moved into specific machine files?
>

I tried to add following patch for new resources, but now it fails with:

[ 141.534545] pxa2xx-ir pxa2xx-ir: can't request region for resource [mem 0x40700000-0x40700100]
[ 141.534574] pxa2xx-ir pxa2xx-ir: resource stuart not defined
[ 141.534656] pxa2xx-ir: probe of pxa2xx-ir failed with error -16

That's because STUART is allocated by normal UART driver at:

http://lxr.free-electrons.com/source/arch/arm/mach-pxa/devices.c#L244

So somehow there must be configuration for STUART used with FICP and STUART alone (probably can be used for normal UART).


diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach-pxa/devices.c
index 3543466..316ffa3 100644
--- a/arch/arm/mach-pxa/devices.c
+++ b/arch/arm/mach-pxa/devices.c
@@ -394,6 +394,26 @@ static struct resource pxa_ir_resources[] = {
.end = IRQ_ICP,
.flags = IORESOURCE_IRQ,
},
+ [2] = {
+ .start = 0x40800000,
+ .end = 0x40800000 + 0x100,
+ .flags = IORESOURCE_MEM,
+ },
+ [3] = {
+ .start = 0x40700000,
+ .end = 0x40700000 + 0x100,
+ .flags = IORESOURCE_MEM,
+ },
+ [4] = {
+ .start = 17,
+ .end = 17,
+ .flags = IORESOURCE_DMA,
+ },
+ [5] = {
+ .start = 18,
+ .end = 18,
+ .flags = IORESOURCE_DMA,
+ },
};

struct platform_device pxa_device_ficp = {
--
1.7.12.1



\
 
 \ /
  Last update: 2015-09-09 03:41    [W:0.075 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site