lkml.org 
[lkml]   [2015]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC tip/core/rcu 3/9] rcu_sync: Add CONFIG_PROVE_RCU checks
On Mon, Sep 07, 2015 at 02:52:47PM +0200, Oleg Nesterov wrote:
> On 09/07, Daniel Wagner wrote:
> >
> > On 08/29/2015 05:35 AM, Paul E. McKenney wrote:
> > > +extern bool __rcu_sync_is_idle(struct rcu_sync *);
> > > +
> > > /**
> > > * rcu_sync_is_idle() - Are readers permitted to use their fastpaths?
> > > * @rsp: Pointer to rcu_sync structure to use for synchronization
> > > @@ -50,7 +52,11 @@ struct rcu_sync {
> > > */
> > > static inline bool rcu_sync_is_idle(struct rcu_sync *rsp)
> > > {
> > > +#ifdef CONFIG_PROVE_RCU
> > > + return __rcu_sync_is_idle(rss);
> >
> > s/rss/rsp?
>
> Hmm, yes.
>
> Paul, it seems that you renamed "rss" to "rsp" globally (I didn't even
> notice this change), but forgot about this one ;)
>
> Should I send the patch or will you fix this yourself?

I did fix it in -rcu, and a few other breakages as well. Most of them
self-inflicted, as usual. However, I am holding off on this series in
order to get it a bit more pre-merge testing. I expect to push this
in v4.4.

Thanx, Paul



\
 
 \ /
  Last update: 2015-09-09 02:01    [W:0.056 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site