lkml.org 
[lkml]   [2015]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 1/2] efi: print unrecognized CPER section
On 09/08/2015 04:29 PM, Jonathan (Zhixiong) Zhang wrote:

> Change-Id: I663a6e3ae6dcf68e4e389f76d555e9106ffee165

You need to strip out the Change-Id's before posting the patch.

> +#define cper_print_hex(pfx, buf, len) \
> + print_hex_dump(pfx, "", \
> + DUMP_PREFIX_OFFSET, ROW_SIZE, GROUP_SIZE, \
> + buf, len, 0)

(buf), (len), 0)

is safer

> + } else {
> + const void *raw_err = gdata + 1;
> + printk("%ssection type: %pUl\n", pfx, sec_type);
> + printk("%ssection length: %d\n", pfx, len);
> + cper_print_hex(newpfx, raw_err, len);

You don't need raw_err. This should work fine:

cper_print_hex(newpfx, gdata + 1, len);

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.


\
 
 \ /
  Last update: 2015-09-09 00:21    [W:0.075 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site