lkml.org 
[lkml]   [2015]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] device property: Don't overwrite addr when failing in device_get_mac_address
From
From: Julien Grall <julien.grall@citrix.com>
Date: Thu, 3 Sep 2015 23:59:50 +0100

> The function device_get_mac_address is trying different property names
> in order to get the mac address. To check the return value, the variable
> addr (which contain the buffer pass by the caller) will be re-used. This
> means that if the previous property is not found, the next property will
> be read using a NULL buffer.
>
> Therefore it's only possible to retrieve the mac if node contains a
> property "mac-address". Fix it by using a temporary buffer for the
> return value.
>
> This has been introduced by commit 4c96b7dc0d393f12c17e0d81db15aa4a820a6ab3
> "Add a matching set of device_ functions for determining mac/phy"
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>

Applied, thanks.


\
 
 \ /
  Last update: 2015-09-08 23:01    [W:0.026 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site