lkml.org 
[lkml]   [2015]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf session: Don't call dump_sample() when evsel is NULL
    Commit-ID:  1b29ac59b1d692c06ec543a5f35e0d9ebb98e003
    Gitweb: http://git.kernel.org/tip/1b29ac59b1d692c06ec543a5f35e0d9ebb98e003
    Author: Kan Liang <kan.liang@intel.com>
    AuthorDate: Thu, 3 Sep 2015 08:31:00 -0400
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Fri, 4 Sep 2015 12:01:04 -0300

    perf session: Don't call dump_sample() when evsel is NULL

    Need to check evsel before passing it to dump_sample().

    Signed-off-by: Kan Liang <kan.liang@intel.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/r/1441283463-51050-5-git-send-email-kan.liang@intel.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/session.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
    index 61669be..23fed17 100644
    --- a/tools/perf/util/session.c
    +++ b/tools/perf/util/session.c
    @@ -1080,11 +1080,11 @@ static int machines__deliver_event(struct machines *machines,

    switch (event->header.type) {
    case PERF_RECORD_SAMPLE:
    - dump_sample(evsel, event, sample);
    if (evsel == NULL) {
    ++evlist->stats.nr_unknown_id;
    return 0;
    }
    + dump_sample(evsel, event, sample);
    if (machine == NULL) {
    ++evlist->stats.nr_unprocessable_samples;
    return 0;

    \
     
     \ /
      Last update: 2015-09-08 17:01    [W:2.627 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site