Messages in this thread | | | Subject | Re: [PATCH v2 4/6] selftests: mqueue: simpification the Makefile | From | Michael Ellerman <> | Date | Tue, 08 Sep 2015 15:47:32 +1000 |
| |
On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote:
> selftests: mqueue: simpification the Makefile
This should be:
selftests/mqueue: Simplify the Makefile
And please write a change log, even for simple commits like this.
You can say something like:
Use make's implict rule for building simple C programs.
> Suggested-by: Michael Ellermani <mpe@ellerman.id.au> > Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> > --- > tools/testing/selftests/mqueue/Makefile | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile > index ca8327f..9f51aaa 100644 > --- a/tools/testing/selftests/mqueue/Makefile > +++ b/tools/testing/selftests/mqueue/Makefile > @@ -1,8 +1,7 @@ > CFLAGS += -O2 > +LDLIBS = -lrt -lpthread -lpopt
Please move the TEST_PROGS line here:
TEST_PROGS := mq_open_tests mq_perf_tests
> -all: > - $(CC) $(CFLAGS) mq_open_tests.c -o mq_open_tests -lrt > - $(CC) $(CFLAGS) -o mq_perf_tests mq_perf_tests.c -lrt -lpthread -lpopt > +all: mq_open_tests mq_perf_tests
So this can become:
all: $(TEST_PROGS)
> > include ../lib.mk
cheers
| |