lkml.org 
[lkml]   [2015]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 6/9] cpufreq: ondemand: queue work for policy->cpus together
On 08-09-15, 03:33, Rafael J. Wysocki wrote:
> > + /* Make sure the work is not canceled on policy->cpus */
>
> I'm not sure what scenario can lead to that. Care to explain?

CPUFREQ_GOV_STOP event called for the policy and so all its works
are in canceled state.

> > + if (!dbs_info->cdbs.shared->policy)
> > continue;
> >
> > next_sampling = jiffies + usecs_to_jiffies(new_rate);
> > appointed_at = dbs_info->cdbs.dwork.timer.expires;
>
> For that to work we always need to do stuff for policy->cpus in sync.
> Do we?

Hmm, we are not in 100% sync for sure. Will check that again.

--
viresh


\
 
 \ /
  Last update: 2015-09-08 04:41    [W:0.114 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site