Messages in this thread | | | Subject | Re: [PATCH v2] stmmac: fix check for phydev being open | From | Sergei Shtylyov <> | Date | Tue, 8 Sep 2015 00:24:30 +0300 |
| |
On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
> Current implementation via IS_ERR(phydev) may make no sense because > of_phy_attach() returns NULL on failure instead of error value.
Not of_phy_connect()?
> Still for checking result of phy_connect() IS_ERR() is useful. > > To address both situations we use combined IS_ERR_OR_NULL() check. > > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> > Cc: linux-kernel@vger.kernel.org > Cc: stable@vger.kernel.org > Cc: David Miller <davem@davemloft.net> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
MBR, Sergei
| |