lkml.org 
[lkml]   [2015]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch
    * Wanpeng Li <wanpeng.li@hotmail.com> [2015-09-06 12:01:10]:


    Hi Wanpeng Li,


    > Hi Srikar,
    > On 8/12/15 12:24 AM, Srikar Dronamraju wrote:
    > >Variable sched_numa_balancing toggles numa_balancing feature. Hence
    > >moving from a simple read mostly variable to a more apt static_branch.
    > >
    > >Suggested-by: Peter Zijlstra <peterz@infradead.org>
    > >Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
    > >
    > This commit breaks Peter's queue:
    >
    > kernel/sched/fair.c: In function ?task_numa_fault?:
    > kernel/sched/fair.c:2072: error: implicit declaration of function
    > ?static_branch_likely?
    > kernel/sched/fair.c: In function ?task_tick_fair?:
    > kernel/sched/fair.c:7867: error: implicit declaration of function
    > ?static_branch_unlikely?
    > make[1]: *** [kernel/sched/fair.o] Error 1
    > make[1]: *** Waiting for unfinished jobs....
    > kernel/sched/core.c:2116: warning: data definition has no type or storage
    > class

    Thanks for reporting. Can you please confirm if you have the commit
    http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=11276d5306b8e5b438a36bbff855fe792d7eaa61

    From 11276d5306b8e5b438a36bbff855fe792d7eaa61 Mon Sep 17 00:00:00 2001
    From: Peter Zijlstra <peterz@infradead.org>
    Date: Fri, 24 Jul 2015 15:09:55 +0200
    Subject: [PATCH] locking/static_keys: Add a new static_key interface


    --
    Thanks and Regards
    Srikar Dronamraju



    \
     
     \ /
      Last update: 2015-09-07 06:21    [W:2.812 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site