lkml.org 
[lkml]   [2015]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro
    Hi Al,

    On 19/08/15 23:07, Al Stone wrote:

    I finally got a chance to try this series on Juno. Well it exposed a
    firmware bug in MADT table :)

    [..]

    > acpi_tbl_entry_handler handler,
    > @@ -245,6 +484,8 @@ acpi_parse_entries(char *id, unsigned long table_size,
    > table_end) {
    > if (entry->type == entry_id
    > && (!max_entries || count < max_entries)) {
    > + if (bad_madt_entry(table_header, entry))
    > + return -EINVAL;

    Not sure if we can have the above check here unconditionally.
    Currently I can see there are 2 other users of acpi_parse_entries i.e.
    PCC and NUMA. So may be it can be made conditional or return success for
    non-MADT tables from bad_madt_entry ?

    Other than that, you can add for ARM64 specific parts:
    Reviewed-and-tested-by: Sudeep Holla <sudeep.holla@arm.com>

    Regards,
    Sudeep


    \
     
     \ /
      Last update: 2015-09-07 17:41    [W:3.217 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site