Messages in this thread | | | Date | Mon, 7 Sep 2015 14:13:38 +0200 | From | Andrey Shvetsov <> | Subject | Re: [PATCH 3/5] staging: most: remove driver owner |
| |
On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > The platform driver core will set the owner value, we do not need to do > it in the module. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c > index 5b0a588..4481a0b 100644 > --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c > +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c > @@ -923,7 +923,6 @@ static struct platform_driver dim2_driver = { > .id_table = dim2_id, > .driver = { > .name = "hdm_dim2", > - .owner = THIS_MODULE, I cannot accept this.
This change is not significant for current kernel, but we still have customers using kernels <= 3.10, where auto assignment of .owner does not exist.
> }, > }; > > -- > 1.9.1 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
| |